Change in vdsm[master]: Do not attempt to configure the iscsid service

fsimonce at redhat.com fsimonce at redhat.com
Wed Nov 23 20:41:41 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Do not attempt to configure the iscsid service
......................................................................


Patch Set 5: (1 inline comment)

> I love patches that remove more lines than they add,
> but functionally support more than before :)

I'm not sure if it supports more than before, maybe we should settle for just removing the lines this time :)

....................................................
File vdsm/storage/iscsi.py
Line 153:     if dRet != 0:
Even if the discovery action failed I don't want take for granted that the db wasn't written to /var/lib/iscsi.
I want to set the node.startup to manual in all cases (and log its failure if it's the case).

--
To view, visit http://gerrit.ovirt.org/305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc0cc114fcc660d8b6b35e6654dfb2592eeb000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list