Change in vdsm[master]: BZ#745510 Fedora RPM revisions

danken at redhat.com danken at redhat.com
Sun Nov 13 12:22:46 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#745510 Fedora RPM revisions
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File build-aux/release.sh
Line 0
Line 1: #!/bin/sh
Line 2: # tags and output releases:
Line 3: #   - v4.9.0 => null (upstream clean)
Line 4: #   - v4.9.0-2-g34e62f => 2.34e62f (upstream dirty)
how Fedora guideline is relevant to our upstream? what would happen in downstream `git-describe` has NF==4?
would you postpone this change for another patch?
Line 5: AWK_RELEASE='
Line 6:     BEGIN { FS="-"; OFS="." }
Line 7:     /^v[0-9]/ {
Line 8:       if (NF == 3) print $2, substr($3, 2)


....................................................
File vdsm.spec.in
Line 14: Source0:        %{vdsm_name}-%{version}.tar.gz
Line 15: BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Line 16: 
Line 17: BuildRequires: python
Line 18: 
I was not convinced - that ref does not disallow this req, and having it explicitly helped we with numerous users failing to build vdsm.
Line 19: Requires: python which
Line 20: Requires: sudo >= 1.7.3
Line 21: Requires: logrotate
Line 22: Requires: python-ethtool


--
To view, visit http://gerrit.usersys.redhat.com/1123
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67e25b5dcbb63b49e9470f2b5736e0eec8a4742a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list