Change in vdsm[master]: Avoid unnecesary produce-invalidate-produce on SD conf chang...

Igor Lvovsky ilvovsky at redhat.com
Sun Nov 13 12:17:11 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Avoid unnecesary produce-invalidate-produce on SD conf changes.
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 535:         """
Line 536:         Avoid handle domains if not owned by pool.
Line 537:         """
Line 538:         if dom.sdUUID not in domainStatuses.iterkeys():
Line 539:             raise se.StorageDomainNotInPool(self.spUUID, dom)
Exception should get sdUUID not domain object
Line 540:         pools = dom.getPools()
Line 541:         if self.spUUID not in pools:
Line 542:             raise se.StorageDomainNotInPool(self.spUUID, dom)
Line 543: 


Line 538:         if dom.sdUUID not in domainStatuses.iterkeys():
Line 539:             raise se.StorageDomainNotInPool(self.spUUID, dom)
Line 540:         pools = dom.getPools()
Line 541:         if self.spUUID not in pools:
Line 542:             raise se.StorageDomainNotInPool(self.spUUID, dom)
Same as above
Line 543: 
Line 544:     @unsecured
Line 545:     def validatePoolMVerHigher(self, masterVersion):
Line 546:         """


--
To view, visit http://gerrit.usersys.redhat.com/1081
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5165b92974145bcd26ca50648a65a6bfe282eb6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list