Change in vdsm[master]: Extracted image related functinality to another class

Igor Lvovsky ilvovsky at redhat.com
Sun Nov 13 07:04:40 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Extracted image related functinality to another class
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 123:         self.domainMonitor = DomainMonitor(self.monitorInterval)
Line 124:         self._imageManipulator = LegacyImageManipulator(os.path.join(self.storage_repository, self.spUUID))
Line 125: 
Line 126:     # I know it exposes everything as unsecured.
Line 127:     # I DON'T CARE. Will be handeled later.
add FIXME
Line 128:     @unsecured
Line 129:     def getImageManipulator(self):
Line 130:         return self._imageManipulator
Line 131: 


--
To view, visit http://gerrit.usersys.redhat.com/1074
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list