Change in vdsm[master]: Move domain monitor out of sp.py

Igor Lvovsky ilvovsky at redhat.com
Sun Nov 13 06:59:56 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Move domain monitor out of sp.py
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1275:     def getRepoStats(self):
Line 1276:         #FIXME : this should actually be  built in HSM
Line 1277:         res = {}
Line 1278:         for sdUUID in self.domainMonitor.monitoredDomains:
Line 1279:             st = self.getStatus(sdUUID)
there is no getStatus, did you mean self.domainMonitor.getStatus
Line 1280:             if st.error is None:
Line 1281:                 code = 0
Line 1282:             elif isinstance(st.error, se.StorageException):
Line 1283:                 code = st.error.code


--
To view, visit http://gerrit.usersys.redhat.com/1094
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list