Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

Gal Hammer ghammer at redhat.com
Wed Aug 31 06:04:46 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: (3 inline comments)

I would prefer that you didn't comment on this. :-)

....................................................
File vdsm/guestIF.py
Line 83:                 old_ips += ' '.join(iface['inet']) + ' '
Important. It needed because old_ips variable contains all the addresses from all the network interfaces (joining a list of strings to a string). I did forgot to write the code that remove the last space, but it doesn't really matter.

Line 217:         if line:
I know. An empty line will throw a json exception without any useful information.

Line 222:             except:
I expect either a json parsing errors or __name__ not found.

Catch what under line 233?

What is exc_info=True? If you mean to dump the stack trace, then calling logging.exception() does that.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list