Change in vdsm[master]: A new JSON-based protocol with the guest's agent.
danken at redhat.com
danken at redhat.com
Tue Aug 30 22:36:18 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: A new JSON-based protocol with the guest's agent.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/guestIF.py
Line 83: old_ips += ' '.join(iface['inet']) + ' '
is the trailing space intentional/important?
Line 217: if line:
but here you also catch empty lines.
Line 222: except:
which exceptions do you expect here? catching everything is not very polite, so maybe you can catch it underl line 233, but in any case - exc_info=True.
--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
More information about the vdsm-patches
mailing list