Change in vdsm[master]: BZ#733909 - get SPM id from lease instead of metadata

Saggi Mizrahi smizrahi at redhat.com
Mon Aug 29 11:46:10 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#733909 - get SPM id from lease instead of metadata
......................................................................


Patch Set 1: (5 inline comments)

....................................................
Commit Message
Line 15: metadata anyways.
It shouldn't but it invalidates the cache before reading so it's not an issue. Also I prefer to use the old way (only metadata) to not disturb our flow.

....................................................
File vdsm/storage/spm.py
Line 723:             spmId = pool.getClusterLockOwner()
it returned int

....................................................
File vdsm/storage/sp.py
Line 499:         self.log.warn("DASDASDASDASDASD %d", self.getMasterDomain()._clusterLock.readTag()[1])
debugging residue I'll fix

Line 1029:             info['spm_id'] = self.getClusterLockOwner()
getMetaParam returned int as well

Line 1277:             spmId = self.getClusterLockOwner()
Same response

--
To view, visit http://gerrit.usersys.redhat.com/860
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I582ae24aa843ad33e48a4cdd1e51b059355d132f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list