Change in vdsm[master]: BZ#733909 - get SPM id from lease instead of metadata

Igor Lvovsky ilvovsky at redhat.com
Mon Aug 29 11:37:45 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: BZ#733909 - get SPM id from lease instead of metadata
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

....................................................
Commit Message
Line 15: metadata anyways.
Sorry, but I can't understand why spmStart should use cached value.
Do you think that it may solve our latest problems with spm lock acquiring?

....................................................
File vdsm/storage/spm.py
Line 723:             spmId = pool.getClusterLockOwner()
this one return int, when getMetaParam returned string? is it OK?

....................................................
File vdsm/storage/sp.py
Line 499:         self.log.warn("DASDASDASDASDASD %d", self.getMasterDomain()._clusterLock.readTag()[1])
What is it ? Does your keyboard stuck  ?   :)

Line 1029:             info['spm_id'] = self.getClusterLockOwner()
this one return int, when getMetaParam returned string?  is it OK?

Line 1277:             spmId = self.getClusterLockOwner()
same as previous comment

--
To view, visit http://gerrit.usersys.redhat.com/860
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I582ae24aa843ad33e48a4cdd1e51b059355d132f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list