Change in vdsm[master]: Related to BZ#730912 - Remove unnecessary verification.

Eduardo Warszawski ewarszaw at redhat.com
Wed Aug 17 09:48:02 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#730912 - Remove unnecessary verification.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 436:                     img = tag[3:]
This patch was sent before the next one.

Was posted for clarity sake :D.
Shows that the REMOVED_PREFIX_CHECK was redundant since the image tag can only start (startswith()) with one only of the prefixes.

Moran verified the next patch.
This patch can be abandoned without any pain, but what about the verified flag of the next one?

--
To view, visit http://gerrit.usersys.redhat.com/816
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I772cd164ddf9ec89abb2791754e4312fc9541c46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list