Change in vdsm[master]: Related to BZ#730912 - Remove unnecessary verification.

danken at redhat.com danken at redhat.com
Wed Aug 17 05:46:52 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#730912 - Remove unnecessary verification.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 436:                     img = tag[3:]
I do not understand this patch at all. afaict, images is never changed in this function. The commit message does not match, and next patch redoes the whole function. please explain what is going on here.

--
To view, visit http://gerrit.usersys.redhat.com/816
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I772cd164ddf9ec89abb2791754e4312fc9541c46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list