Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.

danken at redhat.com danken at redhat.com
Thu Aug 4 19:42:25 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: vdsm: bz#727871: rewrote the messages handling code.
if it's not too hard, please use the commit subject that I suggested before.

And add a (possibly insulting) explanation why the former code sucks.

--
To view, visit http://gerrit.usersys.redhat.com/785
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list