Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.
danken at redhat.com
danken at redhat.com
Wed Aug 3 19:29:08 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
Thanks for sending this, it's an old ugly bug.
....................................................
File vdsm/guestIF.py
Line 257: def _readMessages(self):
_readBuffer() is a better name imo.
Line 261: self._agentTimestamp = time.time()
we used to update this only when s had content. is the change intentional?
Line 269: self._buffer += s
any reason not to put this in lin 260, and drop s altogether?
Line 284: time.sleep(1)
sleep only when there was no new message. (s is None)
--
To view, visit http://gerrit.usersys.redhat.com/785
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
More information about the vdsm-patches
mailing list