[SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure
Jakub Hrozek
jhrozek at redhat.com
Tue Sep 1 11:11:18 UTC 2015
On Tue, Sep 01, 2015 at 12:57:14PM +0200, Pavel Březina wrote:
> On 09/01/2015 11:54 AM, Jakub Hrozek wrote:
> >On Tue, Sep 01, 2015 at 11:28:32AM +0200, Pavel Březina wrote:
> >>>Please see the attached patch, does it look better to you?
> >>
> >>Hi, yes. There is just an indentation error:
> >>
> >>>+ if (fd != -1) {
> >>>+ fret = close(fd);
> >>>+ if (fret == -1) {
> >>>+ fret = errno;
> >>>+ DEBUG(SSSDBG_CRIT_FAILURE,
> >>>+ "close failed [%d][%s].\n", fret, strerror(fret));
> >>
> >> ^^
> >>
> >>>+ }
> >
> >Let's try it again :-)
>
> Ack.
Thanks for the review, pushed to master:
3954cd07dae78bf79136f0854472757d1ed26897
More information about the sssd-devel
mailing list