[SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure
Pavel Březina
pbrezina at redhat.com
Tue Sep 1 10:57:14 UTC 2015
On 09/01/2015 11:54 AM, Jakub Hrozek wrote:
> On Tue, Sep 01, 2015 at 11:28:32AM +0200, Pavel Březina wrote:
>>> Please see the attached patch, does it look better to you?
>>
>> Hi, yes. There is just an indentation error:
>>
>>> + if (fd != -1) {
>>> + fret = close(fd);
>>> + if (fret == -1) {
>>> + fret = errno;
>>> + DEBUG(SSSDBG_CRIT_FAILURE,
>>> + "close failed [%d][%s].\n", fret, strerror(fret));
>>
>> ^^
>>
>>> + }
>
> Let's try it again :-)
Ack.
More information about the sssd-devel
mailing list