[SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

Pavel Reichl preichl at redhat.com
Fri Mar 20 15:58:38 UTC 2015


On 03/20/2015 03:26 PM, Jakub Hrozek wrote:
> On Fri, Mar 20, 2015 at 01:13:35PM +0100, Pavel Reichl wrote:
>>> I wonder why didn't you create a single pwexpire test instead? The file
>>> names are confusing, I would expect tests of authentication and acess
>>> control.
>> The functionality I wanted to test was in 2 separate units (ldap_auth,c,
>> sdap_access.c), but for those units there were no tests. So I created 2 new
>> test units (test_ldap_auth,c, test_sdap_access.c) in hope that more
>> functions from these units will be tested. (code coverage is currently 0.0 %
>> for both modules (https://jhrozek.fedorapeople.org/sssd-coverage/html/providers/ldap/index.html)
> I think this is OK as long as there's nothing specific to the expiration
> tests in the test sources and the sources can be re-used for 'real' auth
> and access checks.
>
> (btw I'm not sure how realistic is to have auth and access /unit/ tests,
> I looked at the sources when you wrote the SSH key expiration patches,
> but it seemed to me integration tests could be a better option)
>
> So I'm fine both ways.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Please see updated patch set.
Thanks!

ci passed:

http://sssd-ci.duckdns.org/logs/job/11/31/summary.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TESTS-test-expiration.patch
Type: text/x-patch
Size: 14359 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150320/6be89cda/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldap-refactor-check_pwexpire_kerberos-to-use-util-fu.patch
Type: text/x-patch
Size: 3111 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150320/6be89cda/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ldap-refactor-nds_check_expired-to-use-util-func.patch
Type: text/x-patch
Size: 2137 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150320/6be89cda/attachment-0002.bin>


More information about the sssd-devel mailing list