[SSSD] [PATCHES] ldap: refactor - reuse sss_utc_to_time_t()

Jakub Hrozek jhrozek at redhat.com
Fri Mar 20 14:26:55 UTC 2015


On Fri, Mar 20, 2015 at 01:13:35PM +0100, Pavel Reichl wrote:
> >I wonder why didn't you create a single pwexpire test instead? The file
> >names are confusing, I would expect tests of authentication and acess
> >control.
> The functionality I wanted to test was in 2 separate units (ldap_auth,c,
> sdap_access.c), but for those units there were no tests. So I created 2 new
> test units (test_ldap_auth,c, test_sdap_access.c) in hope that more
> functions from these units will be tested. (code coverage is currently 0.0 %
> for both modules (https://jhrozek.fedorapeople.org/sssd-coverage/html/providers/ldap/index.html)

I think this is OK as long as there's nothing specific to the expiration
tests in the test sources and the sources can be re-used for 'real' auth
and access checks.

(btw I'm not sure how realistic is to have auth and access /unit/ tests,
I looked at the sources when you wrote the SSH key expiration patches,
but it seemed to me integration tests could be a better option)

So I'm fine both ways.



More information about the sssd-devel mailing list