[SSSD] [PATCH] sssd_sudo always asks for sudo rules of filter_users

Jakub Hrozek jhrozek at redhat.com
Tue Apr 14 12:49:58 UTC 2015


On Tue, Apr 14, 2015 at 01:52:37PM +0200, Pavel Březina wrote:
> On 04/14/2015 10:08 AM, Adam Tkac wrote:
> >On 04/13/2015 06:10 PM, Jakub Hrozek wrote:
> >>On Mon, Apr 13, 2015 at 05:40:41PM +0200, Adam Tkac wrote:
> >>>Hello,
> >>>
> >>>sssd_sudo always asks for sudo rules for users specified in filter_users directive and creates large amount of traffic to LDAP servers. Proposed patch for this is attached (tested on RHEL 6.6, rebuilt sssd-1.11.6-30.el6_6.4). With this patch sssd_sudo no longer queries LDAP for sudo rules of filter_users users.
> >>>
> >>>Regards, Adam
> >>
> >>Thanks for the patch!
> >>
> >>Minor stylish nack -- we tend to use curly braces even around one-line
> >>conditions:
> >>
> >>if (foo == NULL) {
> >>     bar();
> >>}
> >>
> >>It would also be nice to always write a DEBUG message if something
> >>failed:
> >>if (foo == NULL) {
> >>     DEBUG(SSSDBG_CRIT_FAILURE, "foo is NULL!\n");
> >>     goto fail;
> >>}
> >>
> >>Otherwise LGTM.
> >
> >Improved patch is attached.
> >
> >Regards, A
> 
> 
> Ack. Thank you for contribution!

* master: 2a25713afc6beefb11a799903a43f695c5d7a4f9



More information about the sssd-devel mailing list