[SSSD] [PATCH] simple_access-tests: Simplify assertion

Lukas Slebodnik lslebodn at redhat.com
Tue Apr 14 06:52:21 UTC 2015


ehlo,

simple patch is attached.

LS
-------------- next part --------------
>From de73f8b78968ee651874b7561dd0548359b9e5c8 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 6 Mar 2015 20:10:15 +0100
Subject: [PATCH] simple_access-tests: Simplify assertion

The second argument of function check_access_list should not be an empty list.
---
 src/tests/simple_access-tests.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/tests/simple_access-tests.c b/src/tests/simple_access-tests.c
index 5c74eb85f80cbeee8cff456c08d9012babb9a9db..3e8b310eeaf31a85fa7c51cf9fe27f7074c6bfaa 100644
--- a/src/tests/simple_access-tests.c
+++ b/src/tests/simple_access-tests.c
@@ -536,9 +536,7 @@ static void check_access_list(char **list, const char **values)
 {
     int i;
 
-    if (list == NULL) {
-        fail_if(values != NULL, "List is empty, but it shouldn't be");
-    }
+    fail_if(values == NULL, "List is empty, but it shouldn't be");
 
     for (i = 0; list[i] != NULL; i++) {
         fail_if(values[i] == NULL, "List contains too many entries");
-- 
2.3.5



More information about the sssd-devel mailing list