[SSSD] [PATCH] GPO: Check return value of ad_gpo_store_policy_settings

Pavel Reichl preichl at redhat.com
Wed Apr 1 10:22:41 UTC 2015


On 04/01/2015 09:09 AM, Lukas Slebodnik wrote:
> On (01/04/15 09:04), Pavel Reichl wrote:
>> On 04/01/2015 08:51 AM, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> simple patch is attached.
>>> It fixes warning from clang static analyzer.
>>>
>>> LS
>>>
>> Patch LGTM, but I think there is a typo.
>>> 0001-GPO-Check-return-value-of-ad_gpo_store_policy_settin.patch
>>>
>>>
>>>  From 80206c522c25d87bf7592259fe7d7d6ed6835470 Mon Sep 17 00:00:00 2001
>>> From: Lukas Slebodnik<lslebodn at redhat.com>
>>> Date: Fri, 6 Mar 2015 20:42:35 +0100
>>> Subject: [PATCH] GPO: Check return value of ad_gpo_store_policy_settings
>>>
>>> ---
>>>   src/providers/ad/ad_gpo.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
>>> index a9879b41b6b618d4c73156d95378c9bcd2b397c4..8caea392ac778e81704a9742587a89d1bbfefaf1 100644
>>> --- a/src/providers/ad/ad_gpo.c
>>> +++ b/src/providers/ad/ad_gpo.c
>>> @@ -2181,6 +2181,12 @@ ad_gpo_cse_done(struct tevent_req *subreq)
>>>        */
>>>       ret = ad_gpo_store_policy_settings(state->domain,
>>>                                          cse_filtered_gpo->policy_filename);
>>> +    if (ret != EOK) {
>>> +        DEBUG(SSSDBG_OP_FAILURE,
>>> +              "ad_gpo_store_policy_settings failed: [%d](%s}\n",
>> typo - 's/}/)' ?
>>> +              ret, sss_strerror(ret));
>>> +        goto done;
>>> +    }
>>>       state->cse_gpo_index++;
>>>       ret = ad_gpo_cse_step(req);
>>> -- 2.3.4
> It's trap for reviewer.
>
> Updated patch is attached.
>
> LS
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

ACK,
ci passed: http://sssd-ci.duckdns.org/logs/job/12/43/summary.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150401/64279379/attachment.html>


More information about the sssd-devel mailing list