<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 04/01/2015 09:09 AM, Lukas Slebodnik wrote:<br>
    <blockquote cite="mid:20150401070921.GD30096@mail.corp.redhat.com"
      type="cite">
      <pre wrap="">On (01/04/15 09:04), Pavel Reichl wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="">On 04/01/2015 08:51 AM, Lukas Slebodnik wrote:
</pre>
        <blockquote type="cite">
          <pre wrap="">ehlo,

simple patch is attached.
It fixes warning from clang static analyzer.

LS

</pre>
        </blockquote>
        <pre wrap="">Patch LGTM, but I think there is a typo.
</pre>
        <blockquote type="cite">
          <pre wrap="">0001-GPO-Check-return-value-of-ad_gpo_store_policy_settin.patch


>From 80206c522c25d87bf7592259fe7d7d6ed6835470 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik<a class="moz-txt-link-rfc2396E" href="mailto:lslebodn@redhat.com">&lt;lslebodn@redhat.com&gt;</a>
Date: Fri, 6 Mar 2015 20:42:35 +0100
Subject: [PATCH] GPO: Check return value of ad_gpo_store_policy_settings

---
 src/providers/ad/ad_gpo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index a9879b41b6b618d4c73156d95378c9bcd2b397c4..8caea392ac778e81704a9742587a89d1bbfefaf1 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -2181,6 +2181,12 @@ ad_gpo_cse_done(struct tevent_req *subreq)
      */
     ret = ad_gpo_store_policy_settings(state-&gt;domain,
                                        cse_filtered_gpo-&gt;policy_filename);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_OP_FAILURE,
+              "ad_gpo_store_policy_settings failed: [%d](%s}\n",
</pre>
        </blockquote>
        <pre wrap="">typo - 's/}/)' ?
</pre>
        <blockquote type="cite">
          <pre wrap="">+              ret, sss_strerror(ret));
+        goto done;
+    }
     state-&gt;cse_gpo_index++;
     ret = ad_gpo_cse_step(req);
-- 2.3.4
</pre>
        </blockquote>
        <pre wrap="">
</pre>
      </blockquote>
      <pre wrap="">
It's trap for reviewer.

Updated patch is attached.

LS
</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
sssd-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sssd-devel@lists.fedorahosted.org">sssd-devel@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/sssd-devel">https://lists.fedorahosted.org/mailman/listinfo/sssd-devel</a>
</pre>
    </blockquote>
    <br>
    ACK,<br>
    ci passed: <a class="moz-txt-link-freetext" href="http://sssd-ci.duckdns.org/logs/job/12/43/summary.html">http://sssd-ci.duckdns.org/logs/job/12/43/summary.html</a><br>
  </body>
</html>