[SSSD] [PATCH v2] CI: Allow disabling distro-(in)dependent tests

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Thu Sep 11 20:32:25 UTC 2014


On 09/11/2014 07:06 PM, Michal Židek wrote:
> On 09/11/2014 02:44 PM, Nikolai Kondrashov wrote:
>> On 09/11/2014 01:42 PM, Michal Židek wrote:
>>> On 09/04/2014 11:40 AM, Nikolai Kondrashov wrote:
>>>> This version removes the disabling of Valgrind memory leak check,
>>>> which got
>>>> into the first version accidentally and should be (and is) a separate
>>>> patch.
>>>
>>> This patch no longer applies on master. Please rebase.
>>
>> Sure, here's the rebase. Should've checked it earlier myself.
>>
> the patches work, but I have problem with the approach
> they take to solve this issue.
>
> I would like to see the --no-common and --no-distro
> functionality to be built on top of the ticket
> https://fedorahosted.org/sssd/ticket/2425
>
> What I would like to have is option like this:
> --test=<name1>,<name2>,<name3> ...
>
> Where <nameX> will be name of a test or group of tests.
>
> Examples:
> --test=valgrind        run only valgrind
> --test=mock        run only mock builds
> --test=all        run all tests
> --test=essential    run esential tests
> --test=common        run distro independent tests only
> --test=distro        run dis. dependent tests only
> --test=valgrind,mock    run  valgrind and mock
> etc. etc.
>
> Using a command like --test='...' will also have the
> advantage that we will not pollute namespace for other
> options as all the tests or combination of tests are
> parameters of the same option.
>
> I would also keep the -n alias for --no-deps, because I
> use it always, and removing it would be considered a
> regression by me :) .

Wow, you actually use it, nice :)

Sure, I can get it back.

I agree that a generic way to select tests would be better.
However it will also take time and thought to implement and I also wanted to
give a try of convincing you for using Epoxy, which will make that and other
things simpler.

What if I get the "-n" option back and implement "--no-common" and
"--no-distro" for now, so we could make CI faster and have it officially open
to everyone sooner?

These options would not be useful much to anyone running CI locally and nobody
would need to bother how CI server uses them, so there will be little loss in
removing them later.

I promise to fix that ticket some time afterwards, this way or another.

I just think that --essential/--moderate/--rigorous would be bearable for the
start and it is more important to make server CI available sooner. I might be
wrong, though.

What do you think?

Nick



More information about the sssd-devel mailing list