[SSSD] NSS: Add config option to expand homedir template format

Lukas Slebodnik lslebodn at redhat.com
Tue May 27 14:29:10 UTC 2014


On (27/05/14 13:03), Pavel Reichl wrote:
>On Tue, 2014-05-27 at 11:24 +0200, Lukas Slebodnik wrote:
>> O
>> >The fact of passing pointer to the same area in memory to 2 separate
>> >arguments of sss_parse_name() is what I called potential source of bugs.
>> >You said "It seems strange to me" so I hope you know what I mean.
>> It is strange, but it isn't wrong.
>>    * orig_name refers to old string
>>    * homedir_ctx->username will refer to new string.
>> I need to use old string in debug message if function fails.
>I missed that.
It is my fault. I should have explained it better.

The strange (confusing) solution is the next, but it was not used in patches.
    ret = sss_parse_name_const(mem_ctx, dom->names, homedir_ctx->username,
                               NULL, &homedir_ctx->username)

Thank you for review.

LS



More information about the sssd-devel mailing list