[SSSD] [PATCH v2] build: Switch to AM_DISTCHECK_CONFIGURE_FLAGS

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Mon May 26 15:14:48 UTC 2014


On 05/26/2014 04:51 PM, Lukas Slebodnik wrote:
> On (21/05/14 13:30), Nikolai Kondrashov wrote:
>> Use AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
>> DISTCHECK_CONFIGURE_FLAGS to allow using the latter at build time,
>> upon making distcheck target.
>>
>> In particular, the above would allow specifying --with-test-dir option
>> to help archive test data in CI runs, like this:
>>
>>     make distcheck DISTCHECK_CONFIGURE_FLAGS=/dev/shm/ci-test-dir
> I think you want to write next line to the commit description
> make distcheck DISTCHECK_CONFIGURE_FLAGS="--with-test-dir=/dev/shm/ci-test-dir"
>
> Otherwise works as expected.
>
> The configure sctipt was called with two argumets "--with-test-dir"
> and the last one won.
>
> sh-4.2$ grep "$ ../configure" ./sssd-1.11.90/_build/config.log
>    $ ../configure --srcdir=.. --prefix=/dev/shm/sssd_build/sssd-1.11.90/_inst --with-ldb-lib-dir=/dev/shm/sssd_build/sssd-1.11.90/_inst/lib/ldb --enable-all-experimental-features --with-test-dir=/dev/shm --with-test-dir=/dev/shm/ci-test-dir
>
> sh-4.2$ grep "TEST_DIR" ./sssd-1.11.90/_build/config.h
> #define TEST_DIR "/dev/shm/ci-test-dir"
>
> ACK after small change in commit message

Ah, yes, thank you. Fixed.

Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Switch-to-AM_DISTCHECK_CONFIGURE_FLAGS.patch
Type: text/x-patch
Size: 1311 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140526/e21877e9/attachment.bin>


More information about the sssd-devel mailing list