[SSSD] [PATCH] build: Switch to AM_DISTCHECK_CONFIGURE_FLAGS

Lukas Slebodnik lslebodn at redhat.com
Mon May 26 13:51:19 UTC 2014


On (21/05/14 13:30), Nikolai Kondrashov wrote:
>Hi everyone,
>
>This patch will allow passing "--with-test-dir" to configure executed by "make
>distcheck", which is desirable for CI runs.
>
>Nick

>From 8ce9a37aa8b1675d05dc5c4b9eeeb9a345c13b2c Mon Sep 17 00:00:00 2001
>From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
>Date: Tue, 20 May 2014 17:52:43 +0300
>Subject: [PATCH 1/1] build: Switch to AM_DISTCHECK_CONFIGURE_FLAGS
>
>Use AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
>DISTCHECK_CONFIGURE_FLAGS to allow using the latter at build time,
>upon making distcheck target.
>
>In particular, the above would allow specifying --with-test-dir option
>to help archive test data in CI runs, like this:
>
>    make distcheck DISTCHECK_CONFIGURE_FLAGS=/dev/shm/ci-test-dir
I think you want to write next line to the commit description
make distcheck DISTCHECK_CONFIGURE_FLAGS="--with-test-dir=/dev/shm/ci-test-dir"

Otherwise works as expected.

The configure sctipt was called with two argumets "--with-test-dir"
and the last one won.

sh-4.2$ grep "$ ../configure" ./sssd-1.11.90/_build/config.log
  $ ../configure --srcdir=.. --prefix=/dev/shm/sssd_build/sssd-1.11.90/_inst --with-ldb-lib-dir=/dev/shm/sssd_build/sssd-1.11.90/_inst/lib/ldb --enable-all-experimental-features --with-test-dir=/dev/shm --with-test-dir=/dev/shm/ci-test-dir

sh-4.2$ grep "TEST_DIR" ./sssd-1.11.90/_build/config.h
#define TEST_DIR "/dev/shm/ci-test-dir"

ACK after small change in commit message

LS



More information about the sssd-devel mailing list