[SSSD] [PATCH][ding-libs] Collection: remove unused code

Stephen Gallagher sgallagh at redhat.com
Mon May 12 20:24:01 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/11/2014 02:54 PM, Dmitri Pal wrote:
> On 05/09/2014 05:06 PM, Jakub Hrozek wrote:
>> Hi,
>> 
>> see attached patch, just removes unused code.
>> 
>> 
>> _______________________________________________ sssd-devel
>> mailing list sssd-devel at lists.fedorahosted.org 
>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> Interesting. I looked at the code and it seems to be indeed a dead
> code. In the earlier versions it was not. It was used to debug a
> collection to print the type of the element during the debugging.
> There was function to serialize the collection. I do not see it
> now. I suspect that it was removed at some point as we went the
> other way. But I would argue that the ability to print thew types
> of the values in a debug message might be needed in future for
> troubleshooting.
> 
> So I am a bit on the fence about removing this code.

Git history will always be there. It's not hard to resurrect it if we
decide we need it back.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlNxLeEACgkQeiVVYja6o6NxDwCfTlbdQDxEoK8vMw8lEYBXYOxY
3gEAnRRNd+0PcpRBYpMIuRNcCudL+gaw
=3kFn
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list