[SSSD] [PATCH][ding-libs] Collection: remove unused code

Dmitri Pal dpal at redhat.com
Sun May 11 18:54:03 UTC 2014


On 05/09/2014 05:06 PM, Jakub Hrozek wrote:
> Hi,
>
> see attached patch, just removes unused code.
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Interesting. I looked at the code and it seems to be indeed a dead code.
In the earlier versions it was not. It was used to debug a collection to 
print the type of the element during the debugging. There was function 
to serialize the collection. I do not see it now.
I suspect that it was removed at some point as we went the other way. 
But I would argue that the ability to print thew types of the values in 
a debug message might be needed in future for troubleshooting.

So I am a bit on the fence about removing this code.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IdM portfolio
Red Hat, Inc.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140511/5fa264eb/attachment.html>


More information about the sssd-devel mailing list