[SSSD] [PATCH] Unify usage of function gethostname

Jakub Hrozek jhrozek at redhat.com
Tue Jun 3 12:50:39 UTC 2014


On Tue, Jun 03, 2014 at 12:34:48PM +0200, Pavel Březina wrote:
> On 06/02/2014 06:35 AM, Lukas Slebodnik wrote:
> >On (01/06/14 12:24), Simo Sorce wrote:
> >>On Sat, 2014-05-31 at 19:13 +0200, Lukas Slebodnik wrote:
> >>>ehlo,
> >>>
> >>>We used function gethostname on few places but in different way.
> >>>We also used hardcoded values instead of constant HOST_NAME_MAX
> >>
> >>Shouldn't we have a sssd_gethostname() so we can override the hostname
> >>when people configure set things like ipa_hostname = ?
> >>
> >ipa_hostname is ipa specific option and situation will be more complicated
> >with containers use-case.
> >
> >I would prefer to take small steps towards goal.
> >
> >LS
> 
> ipa_hostname and ad_hostname are accessed directly from dp_opts when
> needed so I don't think it would be a real benefit without lots of
> changes. It can wait, but maybe we can file a ticket?
> 
> Ack to the patch.

master: bf6f1b3d49e17b1adf0448c0b06e94b1e52ddffd
sssd-1-11: 8269d3c385ac1686f2dcf778827f04435f1ec4bf



More information about the sssd-devel mailing list