[SSSD] [PATCH] Unify usage of function gethostname

Pavel Březina pbrezina at redhat.com
Tue Jun 3 10:34:48 UTC 2014


On 06/02/2014 06:35 AM, Lukas Slebodnik wrote:
> On (01/06/14 12:24), Simo Sorce wrote:
>> On Sat, 2014-05-31 at 19:13 +0200, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> We used function gethostname on few places but in different way.
>>> We also used hardcoded values instead of constant HOST_NAME_MAX
>>
>> Shouldn't we have a sssd_gethostname() so we can override the hostname
>> when people configure set things like ipa_hostname = ?
>>
> ipa_hostname is ipa specific option and situation will be more complicated
> with containers use-case.
>
> I would prefer to take small steps towards goal.
>
> LS

ipa_hostname and ad_hostname are accessed directly from dp_opts when 
needed so I don't think it would be a real benefit without lots of 
changes. It can wait, but maybe we can file a ticket?

Ack to the patch.




More information about the sssd-devel mailing list