[SSSD] [PATCH v3 4/4] NFSv4 client: add to RPM spec

Noam Meltzer tsnoam at gmail.com
Fri Jul 18 14:11:31 UTC 2014


On Tue, Jul 15, 2014 at 6:28 PM, Jakub Hrozek <jhrozek at redhat.com> wrote:

> On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote:
> > On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek <jhrozek at redhat.com>
> wrote:
> >
> > > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote:
> > > > ---
> > > >  contrib/sssd.spec.in | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
> > > > index b5e7903..8d2f2be 100644
> > > > --- a/contrib/sssd.spec.in
> > > > +++ b/contrib/sssd.spec.in
> > > > @@ -138,6 +138,11 @@ BuildRequires: systemd-devel
> > > >  %if (0%{?with_cifs_utils_plugin} == 1)
> > > >  BuildRequires: cifs-utils-devel
> > > >  %endif
> > > > +%if ((0%{?fedora} >= 15) || (0%{?rhel} >= 7))
> > > > +BuildRequires: libnfsidmap-devel
> > > > +%else
> > > > +BuildRequires: nfs-utils-lib-devel
> > > > +%endif
> > > >
> > > >  # RHEL 5 is too old to support samba4 and the PAC responder
> > > >  %if !0%{?is_rhel5}
> > > > @@ -451,6 +456,7 @@ autoreconf -ivf
> > > >      --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \
> > > >      --enable-nsslibdir=/%{_lib} \
> > > >      --enable-pammoddir=/%{_lib}/security \
> > > > +    --enable-nfsidmaplibdir=%{_libdir}/libnfsidmap \
> > > >      --disable-static \
> > > >      --disable-rpath \
> > > >      %{?with_ccache} \
> > > > @@ -600,6 +606,7 @@ rm -rf $RPM_BUILD_ROOT
> > > >  # 3rd party application libraries
> > > >  %{_libdir}/sssd/modules/libsss_autofs.so
> > > >  %{_libdir}/libsss_sudo.so
> > > > +%{_libdir}/libnfsidmap/sss_nfs.so
> > >
> > > Here I've got a question, the directory %{_libdir}/libnfsidmap seems
> not
> > > to be owned by any package, at least on Fedora-20, however the
> > > individual files are:
> > > $ rpm -qf /usr/lib64/libnfsidmap/
> > > file /usr/lib64/libnfsidmap is not owned by any package
> > > $ rpm -qf /usr/lib64/libnfsidmap/nsswitch.so
> > > libnfsidmap-0.25-8.fc20.x86_64
> > >
> > > The reason I'm curious is that initially I wanted to Require the
> package
> > > that owns this directory..
> > >
> > > Do you agree this is a packaging bug of libnfsidmap ?
> > >
> >
> > I agree
>
> It's been filed for some time already:
>     https://bugzilla.redhat.com/show_bug.cgi?id=986678
> >
> >
> > >
> > > Otherwise ACK to your patch.
>
> Actually, I think we should also add:
>     Requires: libnfsidmap
> to the spec file.
>

I agree. Can you do it while merging the code, or do you want me to send
PATCHv4?


>
> I was wondering for a bit if we should split the plugin to a separate
> subpackage because of this new Requirement, but I think it's too much
> pain for little gain. On the vast majority of systems, libnfsidmap would
> be installed anyway, because it's required by nfs-utils, which provides
> some quite basic binaries like mount.nfs. Also, the size of the library
> is only about 100 kB..
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140718/30be8857/attachment.html>


More information about the sssd-devel mailing list