<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 15, 2014 at 6:28 PM, Jakub Hrozek <span dir="ltr"><<a href="mailto:jhrozek@redhat.com" target="_blank">jhrozek@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Mon, Jul 14, 2014 at 10:10:59PM +0300, Noam Meltzer wrote:<br>
> On Mon, Jul 14, 2014 at 7:30 PM, Jakub Hrozek <<a href="mailto:jhrozek@redhat.com">jhrozek@redhat.com</a>> wrote:<br>
><br>
> > On Fri, Jun 27, 2014 at 09:44:38AM +0300, Noam Meltzer wrote:<br>
> > > ---<br>
> > > contrib/<a href="http://sssd.spec.in" target="_blank">sssd.spec.in</a> | 7 +++++++<br>
> > > 1 file changed, 7 insertions(+)<br>
> > ><br>
> > > diff --git a/contrib/<a href="http://sssd.spec.in" target="_blank">sssd.spec.in</a> b/contrib/<a href="http://sssd.spec.in" target="_blank">sssd.spec.in</a><br>
> > > index b5e7903..8d2f2be 100644<br>
> > > --- a/contrib/<a href="http://sssd.spec.in" target="_blank">sssd.spec.in</a><br>
> > > +++ b/contrib/<a href="http://sssd.spec.in" target="_blank">sssd.spec.in</a><br>
> > > @@ -138,6 +138,11 @@ BuildRequires: systemd-devel<br>
> > > %if (0%{?with_cifs_utils_plugin} == 1)<br>
> > > BuildRequires: cifs-utils-devel<br>
> > > %endif<br>
> > > +%if ((0%{?fedora} >= 15) || (0%{?rhel} >= 7))<br>
> > > +BuildRequires: libnfsidmap-devel<br>
> > > +%else<br>
> > > +BuildRequires: nfs-utils-lib-devel<br>
> > > +%endif<br>
> > ><br>
> > > # RHEL 5 is too old to support samba4 and the PAC responder<br>
> > > %if !0%{?is_rhel5}<br>
> > > @@ -451,6 +456,7 @@ autoreconf -ivf<br>
> > > --with-krb5-rcache-dir=%{_localstatedir}/cache/krb5rcache \<br>
> > > --enable-nsslibdir=/%{_lib} \<br>
> > > --enable-pammoddir=/%{_lib}/security \<br>
> > > + --enable-nfsidmaplibdir=%{_libdir}/libnfsidmap \<br>
> > > --disable-static \<br>
> > > --disable-rpath \<br>
> > > %{?with_ccache} \<br>
> > > @@ -600,6 +606,7 @@ rm -rf $RPM_BUILD_ROOT<br>
> > > # 3rd party application libraries<br>
> > > %{_libdir}/sssd/modules/libsss_autofs.so<br>
> > > %{_libdir}/libsss_sudo.so<br>
> > > +%{_libdir}/libnfsidmap/sss_nfs.so<br>
> ><br>
> > Here I've got a question, the directory %{_libdir}/libnfsidmap seems not<br>
> > to be owned by any package, at least on Fedora-20, however the<br>
> > individual files are:<br>
> > $ rpm -qf /usr/lib64/libnfsidmap/<br>
> > file /usr/lib64/libnfsidmap is not owned by any package<br>
> > $ rpm -qf /usr/lib64/libnfsidmap/nsswitch.so<br>
> > libnfsidmap-0.25-8.fc20.x86_64<br>
> ><br>
> > The reason I'm curious is that initially I wanted to Require the package<br>
> > that owns this directory..<br>
> ><br>
> > Do you agree this is a packaging bug of libnfsidmap ?<br>
> ><br>
><br>
> I agree<br>
<br>
</div></div>It's been filed for some time already:<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=986678" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=986678</a><br>
<div class="">><br>
><br>
> ><br>
> > Otherwise ACK to your patch.<br>
<br>
</div>Actually, I think we should also add:<br>
Requires: libnfsidmap<br>
to the spec file.<br></blockquote><div><br></div><div>I agree. Can you do it while merging the code, or do you want me to send PATCHv4?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I was wondering for a bit if we should split the plugin to a separate<br>
subpackage because of this new Requirement, but I think it's too much<br>
pain for little gain. On the vast majority of systems, libnfsidmap would<br>
be installed anyway, because it's required by nfs-utils, which provides<br>
some quite basic binaries like mount.nfs. Also, the size of the library<br>
is only about 100 kB..<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote></div></div></div>