[SSSD] [PATCH] Use sss_strerror instead of strerror

Lukas Slebodnik lslebodn at redhat.com
Wed Jul 16 14:42:48 UTC 2014


On (16/07/14 16:37), Michal Židek wrote:
>On 05/11/2014 11:10 PM, Jakub Hrozek wrote:
>>I haven't tested this patch to be honest, but then again, there's not
>>so much to test except compiling and a bit of sanity testing..
>>
>>I prefer Michal's version of using sss_strerror explicitly instead of
>>the route Simo proposed to #define strerror as sss_strerror simply
>>because I prefer to see what function gets called right away. The
>>drawback of mass-converting to sss_strerror is that we lose git-blame
>>history somewhat...but given that we have just recently converted the
>>DEBUG messages and strerror is mostly used only around DEBUG messages,
>>I don't think we'd lose much metadata.
>>
>>But I'd like to hear other opinions as well.
>>
>>On Thu, Apr 24, 2014 at 7:03 PM, Michal Židek <mzidek at redhat.com> wrote:
>>>Hello,
>>>
>>>this patch replaces strerror with sss_strerror on some places.
>>>I think it would be OK to use always sss_strerror, but to keep
>>>the patch relatively small I left strerror on places where
>>>we directly print value of errno or return value of some third
>>>party functions that do not (and never will) return our specific
>>>error codes.
>>>
>>>Patch is attached. It may look big (111 files changed), but
>>>there are only few insertions and deletions in each.
>>>
>>>Thanks,
>>>Michal
>>>
>
>Rebased version attached.
>
>Michal
>

>From fce8ba028a10087c2e71781653b65cad733aef25 Mon Sep 17 00:00:00 2001
>From: Michal Zidek <mzidek at redhat.com>
>Date: Thu, 24 Apr 2014 17:26:37 +0200
>Subject: [PATCH] Use sss_strerror instead of strerror.
>
>---
> Makefile.am                                        |  9 +--

//snip

> 111 files changed, 479 insertions(+), 446 deletions(-)
>
>diff --git a/Makefile.am b/Makefile.am
>index 8d3d366..c9defa8 100644
>--- a/Makefile.am
>+++ b/Makefile.am
>@@ -1290,7 +1290,7 @@ resolv_tests_LDADD = \
>     $(SSSD_LIBS) \
>     $(CHECK_LIBS) \
>     $(CARES_LIBS) \
>-    libsss_debug.la \
>+    $(SSSD_INTERNAL_LTLIBS) \
>     libsss_test_common.la
> 
> refcount_tests_SOURCES = \
>@@ -2347,12 +2347,12 @@ krb5_child_CFLAGS = \
>     $(POPT_CFLAGS) \
>     $(KRB5_CFLAGS)
> krb5_child_LDADD = \
>-    libsss_debug.la \
>     $(TALLOC_LIBS) \
>     $(POPT_LIBS) \
>     $(DHASH_LIBS) \
>     $(KRB5_LIBS) \
>-    $(CLIENT_LIBS)
>+    $(CLIENT_LIBS) \
>+    $(SSSD_INTERNAL_LTLIBS)

We decided to use $(NULL) at the end of lists in Makefile.am. So you will not
change two lines with adding new library next time.
see 1746e8b8399da2a7a8da4aace186f66055ccfec1

LS



More information about the sssd-devel mailing list