[SSSD] [PATCH] Use sss_strerror instead of strerror

Michal Židek mzidek at redhat.com
Wed Jul 16 14:37:00 UTC 2014


On 05/11/2014 11:10 PM, Jakub Hrozek wrote:
> I haven't tested this patch to be honest, but then again, there's not
> so much to test except compiling and a bit of sanity testing..
>
> I prefer Michal's version of using sss_strerror explicitly instead of
> the route Simo proposed to #define strerror as sss_strerror simply
> because I prefer to see what function gets called right away. The
> drawback of mass-converting to sss_strerror is that we lose git-blame
> history somewhat...but given that we have just recently converted the
> DEBUG messages and strerror is mostly used only around DEBUG messages,
> I don't think we'd lose much metadata.
>
> But I'd like to hear other opinions as well.
>
> On Thu, Apr 24, 2014 at 7:03 PM, Michal Židek <mzidek at redhat.com> wrote:
>> Hello,
>>
>> this patch replaces strerror with sss_strerror on some places.
>> I think it would be OK to use always sss_strerror, but to keep
>> the patch relatively small I left strerror on places where
>> we directly print value of errno or return value of some third
>> party functions that do not (and never will) return our specific
>> error codes.
>>
>> Patch is attached. It may look big (111 files changed), but
>> there are only few insertions and deletions in each.
>>
>> Thanks,
>> Michal
>>

Rebased version attached.

Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-sss_strerror-instead-of-strerror.patch
Type: text/x-patch
Size: 184173 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140716/c87f9f29/attachment.bin>


More information about the sssd-devel mailing list