[SSSD] [PATCH] Connect to GC during enumeration

Sumit Bose sbose at redhat.com
Wed Jan 29 16:53:41 UTC 2014


On Wed, Jan 29, 2014 at 05:20:55PM +0100, Jakub Hrozek wrote:
> On Wed, Jan 29, 2014 at 04:03:15PM +0100, Sumit Bose wrote:
> > On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote:
> > > On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote:
> > > > On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote:
> > > > > Code looks good and my tests passed, so ACK.
> > > > > 
> > > > > bye,
> > > > > Sumit
> > > > 
> > > > Thank you for the review, pushed to master. There are some conflicts in
> > > > the 1.11 branch, so I'll send patches separately.
> > > 
> > > One conflict occured because 1.11 didn't have the patch
> > > 1101a3da9037f69a556935f2706b844accc468de from master. Because the
> > > conflict resulution would just do the same as that patch, I simply
> > > cherry-picked it from master.
> > > 
> > > With that extra patch applied, the only differences are that sysdb calls
> > > also pass on the sysdb context in 1.11. All patches are attached for
> > > posterity, but also interdiffs in the two patches that changed, for
> > > easier review.
> > 
> > Patches apply and pass some basic tests. ACK.
> > 
> > Btw, I've seen two compiler warning when building 1.11 which seems to be
> > fixed in master. Do you want the fixes for 1.11 as well?
> > 
> > bye,
> > Sumit
> 
> Sure, I would prefer to have a clean build!
> 
> I don't see any warnings with sssd-1-11 and the patches (compiled with
> llvm-3.3-4), though.

I see

make[2]: Entering directory `/home/sbose/sssd/1-11'
  CC       src/providers/krb5/krb5_child-krb5_child.o
../src/providers/krb5/krb5_child.c: In function 'main':
../src/providers/krb5/krb5_child.c:1990:9: warning: 'offline' may be used uninitialized in this function [-Wmaybe-uninitialized]
     ret = k5c_setup(kr, offline);
         ^

which is fixed by commit 46967fe03a7472537baea13d01882e0ebe83d57a and

  CC       src/tests/dlopen_tests-dlopen-tests.o
../src/tests/dlopen-tests.c: In function 'recursive_dlopen':
../src/tests/dlopen-tests.c:102:17: warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result]
         asprintf(errmsg, "dlopen() failed: %s", dlerror());
                 ^

which is fixed by commit 569bbc59e4060160a986d0fea31601a7b7d998fe .

bye,
Sumit
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list