[SSSD] [PATCH] Connect to GC during enumeration
Jakub Hrozek
jhrozek at redhat.com
Wed Jan 29 16:20:55 UTC 2014
On Wed, Jan 29, 2014 at 04:03:15PM +0100, Sumit Bose wrote:
> On Wed, Jan 29, 2014 at 02:53:15PM +0100, Jakub Hrozek wrote:
> > On Wed, Jan 29, 2014 at 02:14:38PM +0100, Jakub Hrozek wrote:
> > > On Wed, Jan 29, 2014 at 01:33:52PM +0100, Sumit Bose wrote:
> > > > Code looks good and my tests passed, so ACK.
> > > >
> > > > bye,
> > > > Sumit
> > >
> > > Thank you for the review, pushed to master. There are some conflicts in
> > > the 1.11 branch, so I'll send patches separately.
> >
> > One conflict occured because 1.11 didn't have the patch
> > 1101a3da9037f69a556935f2706b844accc468de from master. Because the
> > conflict resulution would just do the same as that patch, I simply
> > cherry-picked it from master.
> >
> > With that extra patch applied, the only differences are that sysdb calls
> > also pass on the sysdb context in 1.11. All patches are attached for
> > posterity, but also interdiffs in the two patches that changed, for
> > easier review.
>
> Patches apply and pass some basic tests. ACK.
>
> Btw, I've seen two compiler warning when building 1.11 which seems to be
> fixed in master. Do you want the fixes for 1.11 as well?
>
> bye,
> Sumit
Sure, I would prefer to have a clean build!
I don't see any warnings with sssd-1-11 and the patches (compiled with
llvm-3.3-4), though.
More information about the sssd-devel
mailing list