[SSSD] [PATCH] bashrc_sssd fixes

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Fri Feb 7 13:12:03 UTC 2014


Thanks for review, Stephen.

Here's the fixed version of the patchset.

On 02/06/2014 03:16 PM, Stephen Gallagher wrote:
> Minor nitpick: some lines are now longer than 79 characters.

Thanks, fixed.

> Could you correct the comment on warn() to read that it builds with
> default optimization? Since we are actually setting CFLAGS+= here, it
> really isn't using the defaults.

Done in an additional patch.

> You didn't add "$@" to the sssinstall() function, but I doubt that
> matters (since I doubt anyone is passing extra arguments to restorecon...)

Yes, this was intentional.

> General statement: if we're moving these to functions, it would be
> nice to have real exit codes for them, rather than using && all over
> the place. Checking the output of each phase and printing an error if
> it fails would be useful. This is not a blocker to these patches, but
> nice to think about.

I'm not sure this is necessary, but I'll think about it.

Sincerely,
Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-HW-instead-of-processor-name-as-build-arch.patch
Type: text/x-patch
Size: 947 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140207/5bd76e6b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-functions-not-aliases-in-bashrc_sssd.patch
Type: text/x-patch
Size: 6354 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140207/5bd76e6b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Handle-unbound-variables-in-bashrc_sssd.patch
Type: text/x-patch
Size: 1187 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140207/5bd76e6b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Clarify-CFLAGS-handling-in-bashrc_sssd.patch
Type: text/x-patch
Size: 1578 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140207/5bd76e6b/attachment-0003.bin>


More information about the sssd-devel mailing list