[SSSD] [PATCH] bashrc_sssd fixes

Stephen Gallagher sgallagh at redhat.com
Thu Feb 6 14:16:48 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/06/2014 02:49 PM, Nikolai Kondrashov wrote:
> Hi everyone,
> 
> Attached are several fixes for bashrc_sssd script.
> 
> Sincerely, Nick
> 
> 

Patch 0001: Ack



Patch 0002: Nack

Minor nitpick: some lines are now longer than 79 characters.

Could you correct the comment on warn() to read that it builds with
default optimization? Since we are actually setting CFLAGS+= here, it
really isn't using the defaults.

You didn't add "$@" to the sssinstall() function, but I doubt that
matters (since I doubt anyone is passing extra arguments to restorecon...)

General statement: if we're moving these to functions, it would be
nice to have real exit codes for them, rather than using && all over
the place. Checking the output of each phase and printing an error if
it fails would be useful. This is not a blocker to these patches, but
nice to think about.




Patch 0003: Ack.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLzmVAACgkQeiVVYja6o6NR4QCdHcHzwqFKWSnnPE0DSReWue+O
+mQAmQEfoMbU0rX06K7oDELA0bppP3lM
=pE90
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list