[SSSD] [PATCH] CI: Remove Valgrind leak checking

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Dec 3 16:27:49 UTC 2014


On 12/03/2014 06:19 PM, Nikolai Kondrashov wrote:
> Hi everyone,
>
> The attached patch removes Valgrind leak checking as suggested by Lukas on
> private sssd-ci list:
>
>      Valgrind will ***NEVER*** find memory leaks in sssd. We use talloc for memory
>      allocations and maintaining suppresion database is nightmare from my POV.
>
>      I vote for removing testing memory leaks with valgrind
>
> Personally, I'm not sure if leak checking is completely useless, but perhaps
> it is. Has anyone caught any leaks with this so far?
>
> Regarding maintenance, we haven't had to add any new leak suppressions in more
> than two months, so it doesn't look so bad so far.
>
> However, if we feel this is irritating and/or useless, we should remove it.
>
> Does anyone have an opinion on this?

Oh, and Jakub has said this in response to Lukas:

     We should keep the valgrind tests for checking for unallocated access or
     use-after free.

     Checking for leaks would only make sense if we compiled our external
     libraries (like the idmap library) with malloc instead of talloc.

Nick



More information about the sssd-devel mailing list