[SSSD] [PATCH] CI: Remove Valgrind leak checking

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Dec 3 16:19:08 UTC 2014


Hi everyone,

The attached patch removes Valgrind leak checking as suggested by Lukas on
private sssd-ci list:

     Valgrind will ***NEVER*** find memory leaks in sssd. We use talloc for memory
     allocations and maintaining suppresion database is nightmare from my POV.

     I vote for removing testing memory leaks with valgrind

Personally, I'm not sure if leak checking is completely useless, but perhaps
it is. Has anyone caught any leaks with this so far?

Regarding maintenance, we haven't had to add any new leak suppressions in more
than two months, so it doesn't look so bad so far.

However, if we feel this is irritating and/or useless, we should remove it.

Does anyone have an opinion on this?

Thank you.

Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CI-Remove-Valgrind-leak-checking.patch
Type: text/x-patch
Size: 2593 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141203/4b05cb04/attachment.bin>


More information about the sssd-devel mailing list