[SSSD] [Patch] Cmocka unit test patch for authtok module

Pallavi Jha pallavikumarijha at gmail.com
Mon Nov 11 11:53:04 UTC 2013


Hello,

I am extremely sorry for the inconvenience. The patch is attached with the
mail. Kindly have a look. I will shortly send another patch for authtor
module with the suggested fix.

Thanking You,
Pallavi

On 11 November 2013 17:05, Lukas Slebodnik <lslebodn at redhat.com> wrote:

> On (09/11/13 19:29), Pallavi Jha wrote:
> >Hi
> >
> >I have created the patch and attached it with this mail. Kindly review it.
> >I have commented some of the test as it fails(gives segmentation fault)
> >when authtoken is NULL. I think we should test tok for NULL before
> >accessing its elements. Please correct me if am wrong.
> >
> >for example :
> >
> >uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
> >{
> >    return tok->data;
> >}
> >
> >This should be written as:
> >
> >uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)
> >{
> >    if(!tok) {
> >        return EINVAL;
> >    }
> >    return tok->data;
> >}
> >
> >Thanking You,
> >Pallavi
>
> I cannot find any attachment.
>
> LS
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131111/62da2b72/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cmocka-unit-test-for-authtok-module-added.patch
Type: text/x-patch
Size: 10392 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131111/62da2b72/attachment.bin>


More information about the sssd-devel mailing list