<div dir="ltr"><div>Hello,<br><br></div>I am extremely sorry for the inconvenience. The patch is attached with the mail. Kindly have a look. I will shortly send another patch for authtor module with the suggested fix.<br><div class="gmail_extra">
<br></div><div class="gmail_extra">Thanking You,<br></div><div class="gmail_extra">Pallavi<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 11 November 2013 17:05, Lukas Slebodnik <span dir="ltr"><<a href="mailto:lslebodn@redhat.com" target="_blank">lslebodn@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On (09/11/13 19:29), Pallavi Jha wrote:<br>
>Hi<br>
><br>
>I have created the patch and attached it with this mail. Kindly review it.<br>
>I have commented some of the test as it fails(gives segmentation fault)<br>
>when authtoken is NULL. I think we should test tok for NULL before<br>
>accessing its elements. Please correct me if am wrong.<br>
><br>
>for example :<br>
><br>
>uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)<br>
>{<br>
> return tok->data;<br>
>}<br>
><br>
>This should be written as:<br>
><br>
>uint8_t *sss_authtok_get_data(struct sss_auth_token *tok)<br>
>{<br>
> if(!tok) {<br>
> return EINVAL;<br>
> }<br>
> return tok->data;<br>
>}<br>
><br>
>Thanking You,<br>
>Pallavi<br>
<br>
</div></div>I cannot find any attachment.<br>
<span class="HOEnZb"><font color="#888888"><br>
LS<br>
</font></span></blockquote></div><br></div></div>