[SSSD] [PATCH] Use permissive modify during sysdb upgrade

Dmitri Pal dpal at redhat.com
Wed Jan 23 20:47:51 UTC 2013


On 01/23/2013 03:29 PM, Simo Sorce wrote:
> On Wed, 2013-01-23 at 12:51 -0500, Dmitri Pal wrote:
>> On 01/23/2013 11:21 AM, Jakub Hrozek wrote:
>>> +/*
>>> + * The wrapper around ldb_modify that uses LDB_CONTROL_PERMISSIVE_MODIFY_OID
>>> + * so that on adds entries that already exist are skipped and similarly
>>> + * entries that are missing are ignored on deletes
>>> + */
>> A nitpick. This comment needs some rephrasing. "... adds entries ..."
>> seems wrong.
>> Probably a one liner.
>>
> Read a , between adds and entries.
>
> Not the clearest language but I thin it is fine as is.
If you "thin" then I am O :-)

> Simo.
>


-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/






More information about the sssd-devel mailing list