[SSSD] [PATCH] Use permissive modify during sysdb upgrade

Simo Sorce simo at redhat.com
Wed Jan 23 20:29:08 UTC 2013


On Wed, 2013-01-23 at 12:51 -0500, Dmitri Pal wrote:
> On 01/23/2013 11:21 AM, Jakub Hrozek wrote:
> > +/*
> > + * The wrapper around ldb_modify that uses LDB_CONTROL_PERMISSIVE_MODIFY_OID
> > + * so that on adds entries that already exist are skipped and similarly
> > + * entries that are missing are ignored on deletes
> > + */
> 
> A nitpick. This comment needs some rephrasing. "... adds entries ..."
> seems wrong.
> Probably a one liner.
> 

Read a , between adds and entries.

Not the clearest language but I thin it is fine as is.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list