[SSSD] [PATCH] autofs: Use SAFEALIGN_SET_UINT32 instead of SAFEALIGN_COPY_UINT32

Jakub Hrozek jhrozek at redhat.com
Wed Jan 16 14:35:14 UTC 2013


On Wed, Jan 16, 2013 at 08:20:34AM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Wed 16 Jan 2013 03:41:33 AM EST, Jakub Hrozek wrote:
> > The attached patch fixes an endianess issue where we were copying size_t
> > into uint32_t which broke on Big Endian machines and in general using
> > the _SET macro is cleaner as in internally assigns to a exact sized
> > variable.
> >
> 
> 
> Patch is good. Ack.
> 
> However, it's become very clear that the use of these macros is
> difficult to grok and we should seriously think about renaming them to
> make their function more clear. I've opened
> https://fedorahosted.org/sssd/ticket/1772 to track this.

Pushed to master and sssd-1-9



More information about the sssd-devel mailing list