[SSSD] [PATCH] autofs: Use SAFEALIGN_SET_UINT32 instead of SAFEALIGN_COPY_UINT32

Stephen Gallagher sgallagh at redhat.com
Wed Jan 16 13:20:34 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed 16 Jan 2013 03:41:33 AM EST, Jakub Hrozek wrote:
> The attached patch fixes an endianess issue where we were copying size_t
> into uint32_t which broke on Big Endian machines and in general using
> the _SET macro is cleaner as in internally assigns to a exact sized
> variable.
>


Patch is good. Ack.

However, it's become very clear that the use of these macros is
difficult to grok and we should seriously think about renaming them to
make their function more clear. I've opened
https://fedorahosted.org/sssd/ticket/1772 to track this.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlD2qSIACgkQeiVVYja6o6M9HQCeI02IZ30EP+mQ3aXz38dysRGV
YzgAoKyQIA6u8ZLMFJqRXFXMY9lELMZx
=vvtV
-----END PGP SIGNATURE-----




More information about the sssd-devel mailing list