[SSSD] [PATCHES] Enable sending DEBUG logs to journald

Stephen Gallagher sgallagh at redhat.com
Fri Dec 20 22:05:56 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

All of these patches require Nikolai's "DEBUG Macro Refactoring v3"
patches to be applied first.




Patch 0001: Allow debug_fn to process __FILE__ and __LINE__

In preparation for enabling journald support for the DEBUG logs, we
will need to be able to pass in certain additional arguments that will
be required, specifically the code file and line number.

We will be able to optionally enable this in the file-based logs as well
if we so choose, but for right now we will avoid breaking the log
format on disk.


Patch 0002: Enable sending structured debug logs to journald

We are now able to send structured debug logs to journald, tagged with
the code file, line number and domain that the log pertains to. To
enable this functionality, SSSD must be configured at build-time with
- --with-syslog=journald and must be launched without -f/--debug-to-files

This behavior is nearly identical to how SSSD will function today on a
systemd-based system if --debug-to-files is disabled, since it will
redirect stdout and stderr into journald. This patch merely enhances
the situation to send structured logs instead of simple string messages.


Patch 0003: BUILD: Build with journald support by default on Fedora

The journal provided by systemd gives us structured logging
capabilities that we should be taking advantage of.

Note: this patch explicitly does not change the systemd unit file for
SSSD. Right now, an administrator will need to manually remove the
'-f' from ExecStart in the unit file to send debug logs to journald. I
suspect we'll want to discuss this before we make it the default. This
patch DOES change the default for sss_log messages to use
sd_journal_send() instead of straight log() for those messages that we
traditionally sent to the syslog (such as login events). This is code
that has been in place for some time now, but has not been the default
because we hadn't build with --with-syslog=journald.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlK0v0QACgkQeiVVYja6o6NwxgCfWnU4IbYyJPXxPe83zWjjsCHt
cG8AnitRgM9CAUjHM2ofYg3TgcUxCyCC
=Fara
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DEBUG-Allow-debug_fn-to-process-__FILE__-and-__LINE_.patch
Type: text/x-patch
Size: 3289 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-DEBUG-Enable-sending-structured-debug-logs-to-journa.patch
Type: text/x-patch
Size: 3331 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-BUILD-Build-with-journald-support-by-default-on-Fedo.patch
Type: text/x-patch
Size: 1798 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DEBUG-Allow-debug_fn-to-process-__FILE__-and-__LINE_.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-DEBUG-Enable-sending-structured-debug-logs-to-journa.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-BUILD-Build-with-journald-support-by-default-on-Fedo.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131220/16c114f2/attachment-0002.sig>


More information about the sssd-devel mailing list