[SSSD] [PATCH] sss_cache: support for subdomains

Jakub Hrozek jhrozek at redhat.com
Fri Apr 12 14:57:41 UTC 2013


On Thu, Apr 11, 2013 at 11:35:52AM +0200, Michal Židek wrote:
> New patch attached.
> 
> Thanks
> Michal
> 
> +        if (IS_SUBDOMAIN(dinfo)) {
> +            name_lower = sss_tc_utf8_str_tolower(tmp_ctx, parsed_name);
> +            domain_lower = sss_tc_utf8_str_tolower(tmp_ctx, parsed_domain);
> +            if (!name_lower || !domain_lower) {
> +                DEBUG(SSSDBG_CRIT_FAILURE, ("Out of memory\n"));
> +                ret = ENOMEM;
> +                goto done;
> +            }

One last nitpick -- while this code is technically correct now, it might not
be in future, we should also check the case_sensitive flag in dinfo and
only lowercase based on the value of the flag.



More information about the sssd-devel mailing list