[SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

Ariel Barria olivares73 at hotmail.com
Tue Apr 9 16:50:35 UTC 2013


> Hi Ariel,
> 
> you don't have to duplicate the case statements in a switch statement if
> both should yield the same result. Instead of:
> 
> +        case EPERM:
> +            DEBUG(SSSDBG_CRIT_FAILURE,
> +                 ("Not enough permission to read configuration file.\n"));
> +            break;
> +        case EACCES:
> +            DEBUG(SSSDBG_CRIT_FAILURE,
> +                 ("Not enough permission to read configuration file.\n"));
> +            break;
> 
> You can use:
> +        case EPERM:
> +        case EACCES:
> +            DEBUG(SSSDBG_CRIT_FAILURE,
> +                 ("Not enough permission to read configuration file.\n"));
> +            break;

Ok, thank you

> Also instead of "Not enough permission" I would rather say
> "Insufficient permissions".


I am hopeful ^_^

> Almost there :)

new patch
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130409/983da363/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Confusing-error-messages-for-invalid-sssd.conf.patch
Type: application/octet-stream
Size: 1985 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130409/983da363/attachment.obj>


More information about the sssd-devel mailing list