[SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf
Jakub Hrozek
jhrozek at redhat.com
Mon Apr 8 22:17:47 UTC 2013
On Wed, Apr 03, 2013 at 03:27:29PM -0500, Ariel Barria wrote:
> thanks for your comments.
> done.
>
Hi Ariel,
you don't have to duplicate the case statements in a switch statement if
both should yield the same result. Instead of:
+ case EPERM:
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ ("Not enough permission to read configuration file.\n"));
+ break;
+ case EACCES:
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ ("Not enough permission to read configuration file.\n"));
+ break;
You can use:
+ case EPERM:
+ case EACCES:
+ DEBUG(SSSDBG_CRIT_FAILURE,
+ ("Not enough permission to read configuration file.\n"));
+ break;
Also instead of "Not enough permission" I would rather say
"Insufficient permissions".
Almost there :)
More information about the sssd-devel
mailing list