[SSSD] [PATCH] Check for the correct variables

Jakub Hrozek jhrozek at redhat.com
Fri Apr 5 10:07:59 UTC 2013


Another Coverity bug..

https://fedorahosted.org/sssd/ticket/1864
-------------- next part --------------
>From 5ba13376f1fd79927cd1ac5a5ef6f0bf99802a48 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 4 Apr 2013 20:36:43 +0200
Subject: [PATCH] Check for the correct variables

https://fedorahosted.org/sssd/ticket/1864
---
 src/providers/dp_pam_data_util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/providers/dp_pam_data_util.c b/src/providers/dp_pam_data_util.c
index 4c33f58369322bc6ab2512990d334155f7354a68..2bc5368f79ca2f721e299128cfd8ca5cbe07c343 100644
--- a/src/providers/dp_pam_data_util.c
+++ b/src/providers/dp_pam_data_util.c
@@ -70,13 +70,13 @@ struct pam_data *create_pam_data(TALLOC_CTX *mem_ctx)
     }
 
     pd->authtok = sss_authtok_new(pd);
-    if (pd == NULL) {
+    if (pd->authtok == NULL) {
         DEBUG(SSSDBG_CRIT_FAILURE, ("talloc_zero failed.\n"));
         goto failed;
     }
 
     pd->newauthtok = sss_authtok_new(pd);
-    if (pd == NULL) {
+    if (pd->newauthtok == NULL) {
         DEBUG(SSSDBG_CRIT_FAILURE, ("talloc_zero failed.\n"));
         goto failed;
     }
-- 
1.8.1.4



More information about the sssd-devel mailing list